feat: update solc version #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OliverNChalk
approved these changes
Nov 10, 2024
added note in README regarding this, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested both solady's and openzeppelin's ReentrancyGuardTransient. This time round solady's one is actually more inefficient because it checks if we're on mainnet and only uses it there
with the new compiler, it supports using
requirewith custom errors now. Changed our code to that as it is more idiomatic solidityadded a rule in solhint for now as this
requirewith custom error thing is only recently supported. see allowgas-custom-errorsrule to properly handle custom errors inside require statements protofire/solhint#602